Refactor Relation<DistributionType> to Relation<ValueType> #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyfertig
approved these changes
Jun 26, 2024
| @@ -82,6 +75,15 @@ class Relation { | |||
| } | |||
| } | |||
|
|
|||
| Distribution<ValueType>* make_new_distribution() { | |||
There was a problem hiding this comment.
I think the answer is no, but is there any chance this could cause problems once DistributionVariant contains Distribution subclasses with the same ValueType?
There was a problem hiding this comment.
I don't think so. The only way the code here could go wrong is if relation_from_spec somehow returned the wrong type of Relation for a DistributionSpec -- for example, if it returned a Relation<bool> for a dist_spec that when passed to cluster_prior_from_spec returned a Distribution<double>.
But if that happened, lots of other things would go wrong, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has lots of advantages, including the fact that new Distributions no longer need to touch relation_variant.*
In general, I think it is a code smell for a class to be templated over a type that doesn't appear in its methods (ValueType appears in Relation's methods, but DistributionType doesn't .)
Plus fixed some memory leaks.
Plus added a typename_playground that makes it easier to iteratively write decltype and typename code and figure out what is going wrong.